Add support for negated addresses #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluhm
requested changes
Jan 24, 2024
added 2 commits
January 25, 2024 12:12
Static addresses can now be negated by prefixing them with the '!' operator. Negated addresses will be loaded into the configured pf tables immediately when pfresolved starts and will prevent the pf tables from matching these addresses. If a host resolves to such an address it will just reference the negated address internally, preventing the resolved address from being added to the pf table in the non-negated form.
Test that negated addresses are added into pf tables and that hosts resolving to these addresses won't have their addresses added to the table. Test that networks cannot be negated. Test that the same address cannot be specified in normal and negated form.
CaBeckmann
force-pushed
the
address_negation
branch
from
c4ff140 to
c60c212
Compare
bluhm
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static addresses can now be negated by prefixing them with the '!'
operator. Negated addresses will be loaded into the configured pf tables
immediately when pfresolved starts and will prevent the pf tables from
matching these addresses.
If a host resolves to such an address it will just reference the negated
address internally, preventing the resolved address from being added to
the pf table in the non-negated form.
Also add tests for this feature:
resolving to these addresses won't have their addresses added to the
table.
form.