Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rss): move RSS reader to its own folder #188

Merged
merged 16 commits into from
Aug 5, 2024
Merged

refactor(rss): move RSS reader to its own folder #188

merged 16 commits into from
Aug 5, 2024

Conversation

Guts
Copy link
Member

@Guts Guts commented Aug 1, 2024

No description provided.

@Guts Guts marked this pull request as draft August 2, 2024 08:44
@Guts Guts self-assigned this Aug 2, 2024
@Guts Guts force-pushed the refactor/sanitize-rss-reader branch from c78892a to a8aac5b Compare August 2, 2024 08:44
@github-actions github-actions bot added the UI User interface: forms, widgets... label Aug 2, 2024
@Guts Guts marked this pull request as ready for review August 2, 2024 15:39
@Guts Guts added enhancement New feature or request and removed UI User interface: forms, widgets... labels Aug 2, 2024
@github-actions github-actions bot added the UI User interface: forms, widgets... label Aug 2, 2024
@Guts
Copy link
Member Author

Guts commented Aug 2, 2024

@gounux bon pour rewiew

gounux
gounux reviewed Aug 4, 2024
View reviewed changes
Copy link
Contributor

@gounux gounux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super ! Un bon coup de clean bien sympa.

J'ai juste quelques remarques d'ordre secondaire concernant l'utilisation de constantes dans les log_level et les tr des logs : utiles ou futiles ?

qtribu/logic/news_feed/rss_reader.py Outdated Show resolved Hide resolved
qtribu/logic/news_feed/rss_reader.py Outdated Show resolved Hide resolved
qtribu/logic/news_feed/rss_reader.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Guts Guts merged commit 9bba760 into main Aug 5, 2024
10 checks passed
@Guts Guts deleted the refactor/sanitize-rss-reader branch August 5, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gounux gounux gounux left review comments

Assignees

@Guts Guts

Labels
enhancement New feature or request UI User interface: forms, widgets...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Guts @gounux