QtWebKitWidgets is no longer available #99
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 21.50% 21.52% +0.01%
==========================================
Files 17 17
Lines 730 734 +4
Branches 76 76
==========================================
+ Hits 157 158 +1
- Misses 572 575 +3
Partials 1 1
|
|
Hi @kikislater , Thanks for your interest and PR! Can you fix the linter error please? Does this change affect compatible QGIS versions? |
|
Please wait, could be distribution specific case ... |
|
So, what should we do? @lbartoletti any idea? |
|
Asking Qgis dev's again about QtWebkit (and its pyQt module) is the best IMO |
QtWebKitWidgets is no longer available http://doc.qt.io/qt-5/qtwebenginewidgets-qtwebkitportingguide.html
for more information, see https://pre-commit.ci
|
|
@Guts @lbartoletti So I haven't followed the behaviour of qtwebkit in Qgis, what will happen to qtwebkit in Qgis, will it still be needed? I've come to understand that removing it would cause problems with Qgis 3D, which needs qtwebkit, so if you have any more info, please let me know! |
As discussed in geotribu#99, QtWebKit is deprecated. The previous fix was not portable. Even when QGIS has QtWebKitWidgets, it fails if not present on the system. This change adopts a more sustainable method using only QtWebEngineWidgets, which will also be available in Qt6. Additionally, instead of calling PyQt (which can be PyQt5 or PyQt6 depending on the system), we now use the link provided by QGIS with qgis.PyQt.
QtWebKitWidgets is no longer available
http://doc.qt.io/qt-5/qtwebenginewidgets-qtwebkitportingguide.html