feat (webapp): show open position #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
luckysori
reviewed
Jan 23, 2024
| @@ -110,3 +110,6 @@ Cargo.lock | |||
| *.pdb | |||
|
|
|||
| # End of https://www.toptal.com/developers/gitignore/api/flutter,dart,rust | |||
|
|
|||
| # data directory for webapp | |||
| data | |||
There was a problem hiding this comment.
I thought we were meaning to share the data directory with the root of the project. This is not wrong though.
There was a problem hiding this comment.
Yea, but if you run cargo run from the sub folder it will generate this which is not wrong but annoying to have :)
webapp/src/api.rs
Outdated
| .to_f32() | ||
| .context("To be able to parse leverage into f32")?, | ||
| contract_symbol: ContractSymbol::BtcUsd, | ||
| direction: Direction::Long, |
There was a problem hiding this comment.
📣 I guess you don't want to hard-code this.
mobile/native/src/trade/order/mod.rs
Outdated
| @@ -13,7 +15,7 @@ mod orderbook_client; | |||
| // When naming this the same as `api_model::order::OrderType` the generated code somehow uses | |||
| // `trade::OrderType` and contains errors, hence different name is used. | |||
| // This is likely a bug in frb. | |||
| #[derive(Debug, Clone, Copy, PartialEq)] | |||
| #[derive(Debug, Clone, Copy, PartialEq, Serialize, Deserialize)] | |||
There was a problem hiding this comment.
🔧 I can't see why we need this change. What am I missing?
There was a problem hiding this comment.
good catch, I guess I was using the wrong types at first
| const host = "localhost"; | ||
|
|
||
| final response = await http.get(Uri.http('$host:$port', '/api/history')); | ||
| final response = await HttpClientManager.instance.get(Uri(path: '/api/history')); |
There was a problem hiding this comment.
🔧 Name of file has typo.
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
This will just add the text from `FlutterError` in front of the already thrown exception. Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
with this we can at ease call endpoints from rust while in dev and while in deploy mode Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
Note: it's not responsive yet and doesn't look good on a small screen Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
bonomat
force-pushed
the
feat/create-orders
branch
from
634b35e to
80ca109
Compare
luckysori
approved these changes
Jan 23, 2024
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
|
Played around with the design a bit. A bit better but not perfect yet: 
|
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bit of a PITA 🙈
resolves #1863