Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): show in app survey #1964

Merged
merged 2 commits into from
Feb 6, 2024
Merged

feat(mobile): show in app survey #1964

merged 2 commits into from
Feb 6, 2024

Conversation

bonomat
Copy link
Contributor

@bonomat bonomat commented Feb 5, 2024

resolves #1810

Feature in a nutshell:

  • the coordinator's db has the polls and their possible choices.
  • polls can be disabled or enabled in the db
  • answers are also stored in the db
  • the user caches on their side if the poll was already answered
  • the user can also decide to ignore the poll forever (in case he doesn't want to give an answer).

With this we can also send messages to all users which are shown in app :)

Screen.Recording.2024-02-05.at.4.00.49.pm.mov

@SXBT69
Copy link
Contributor

SXBT69 commented Feb 5, 2024

It's great!

questions :

-> Can we run different polls like this on different screens (or just on homescreen)?
-> Can we condition a poll (e.g. whether the user has already taken a certain action in his journey, or not)?

@bonomat
Copy link
Contributor Author

bonomat commented Feb 5, 2024

-> Can we run different polls like this on different screens (or just on homescreen)?
-> Can we condition a poll (e.g. whether the user has already taken a certain action in his journey, or not)?

Both questions: not yet, but keep ideas coming and we might add them in the future :)

Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

just a couple of nits

coordinator/src/db/polls.rs Outdated Show resolved Hide resolved
coordinator/src/db/polls.rs Outdated Show resolved Hide resolved
coordinator/src/db/polls.rs Outdated Show resolved Hide resolved
coordinator/src/routes.rs Outdated Show resolved Hide resolved
mobile/lib/common/poll_widget.dart Show resolved Hide resolved
mobile/lib/util/poll_change_notified.dart Outdated Show resolved Hide resolved
@bonomat bonomat enabled auto-merge February 6, 2024 18:37
@bonomat bonomat added this pull request to the merge queue Feb 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2024
@bonomat bonomat added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit 3ffb258 Feb 6, 2024
9 checks passed
@bonomat bonomat deleted the feat/in-app-polls branch February 6, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to display a link to a survey in the app
3 participants