Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coordinator): sort dlc channels by state #1967

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

bonomat
Copy link
Contributor

@bonomat bonomat commented Feb 6, 2024

This will sort the channels retrieved via /api/admin/dlc_channels by their state first and then by their signed_channel_stateif thestate` is equal.

Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks! would be great if the dlc channel would also include a timestamp 🙈

@bonomat bonomat added this pull request to the merge queue Feb 6, 2024
@bonomat
Copy link
Contributor Author

bonomat commented Feb 6, 2024

cool thanks! would be great if the dlc channel would also include a timestamp 🙈

Yea, I shortly thought about fetching the block height for each funding tx and sort it accordingly but then left it 😬

Merged via the queue into get10101:main with commit f3490a5 Feb 6, 2024
10 checks passed
@bonomat bonomat deleted the feat/sort-dlc-channels-api branch February 6, 2024 10:03
@holzeis
Copy link
Contributor

holzeis commented Feb 6, 2024

cool thanks! would be great if the dlc channel would also include a timestamp 🙈

Yea, I shortly thought about fetching the block height for each funding tx and sort it accordingly but then left it 😬

A simple change to rust-dlc adding the timestamp to the channel should also do it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants