Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to increase the number of addresses to sync for #2000

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

bonomat
Copy link
Contributor

@bonomat bonomat commented Feb 9, 2024

I've decided against putting it into the recovery screen as the recommendation should be to increase this number incrementally. The reason is, the higher they gap, the slower the sync.
If this setting would have been only available on the recover screen, a user might need to reset the app again to sync again, hence, it is kinda required to be used from a fully setup app.
I've created a new category in the settings screen, which can come handy in the future, e.g. edit the esplora endpoint.

This fixes a problem where we don't see money in the wallet after recovering the wallet.

Simulator.Screen.Recording.-.iPhone.15.-.2024-02-09.at.13.32.06.mp4

Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

crossAxisAlignment: CrossAxisAlignment.start,
children: [
const Text(
"The amount of addresses to sync for (at least). Once you confirm, a full wallet sync will be performed. The higher the gap is, the longer the sync will take. Hence, we recommend syncing incrementally.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Shouldn't we also recommend to set the gap back to a smaller number after the wallet has been successfully synced?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't :) Once you've increased it there is no way back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if these syncs get less painful with the newest versions of bdk, since the wallet can be used during the sync.

@bonomat bonomat force-pushed the feat/change-lookahead branch from 1cb802a to cdf2f83 Compare February 9, 2024 12:58
@bonomat bonomat enabled auto-merge February 9, 2024 12:58
@bonomat bonomat force-pushed the feat/change-lookahead branch from cdf2f83 to cf9a826 Compare February 9, 2024 13:02
@bonomat bonomat added this pull request to the merge queue Feb 9, 2024
Merged via the queue into main with commit 926a895 Feb 9, 2024
9 checks passed
@bonomat bonomat deleted the feat/change-lookahead branch February 9, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants