Do not overpay funding transaction fees by 2x #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luckysori
changed the title
luckysori
changed the title
luckysori
force-pushed
the
fix/rust-dlc-fees
branch
from
3348fd7 to
7c66640
Compare
luckysori
commented
Feb 14, 2024
| Arc<Node<TenTenOneInMemoryStorage, InMemoryStore>>, | ||
| #[tokio::test(flavor = "multi_thread")] | ||
| #[ignore] | ||
| async fn can_open_channel_with_min_inputs() { |
There was a problem hiding this comment.
We should move this test to rust-dlc eventually, but our tests are easier to write for me.
luckysori
commented
Feb 14, 2024
Comment on lines
+265
to
+268
| let expected_fund_tx_fee = 252 * fee_rate_sats_per_vbyte; | ||
|
|
||
| // This also depends on the fee rate, but the formula is a bit more involved. | ||
| let fee_reserve = 880; |
There was a problem hiding this comment.
I can work on using constants defined by rust-dlc, to make all this clearer and less flaky on rust-dlc upgrades. But I think this suffices for now.
holzeis
approved these changes
Feb 14, 2024
Once the funding transaction is constructed, `rust-dlc` allocates more fees than are needed to pay for the funding transaction.
luckysori
force-pushed
the
fix/rust-dlc-fees
branch
from
7c66640 to
293bf4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2022.
3348fd7 adds 3 patches to our
rust-dlcbranch1:Only the last one is relevant for this PR, but the other ones are probably good too.
Footnotes
Atm the changes live in a separate branch: https://github.com/p2pderivatives/rust-dlc/commits/feature/ln-dlc-channels-10101-with-sign-psbt-fee-fix/. ↩