Add unique_end_date constraint to funding_rates table
#2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What will happen if we get a duplicate entry. Is the error simply logged? |
Good question. An error would be logged, but it would also mean that any other rows in the batch would be ignored. I've updated the patch to fix this: https://github.com/get10101/10101/compare/fc36c9a54b22eeda84dccf463a872bc9c7b53543..23ac948ab64eda8cbe7a06abd343a0b62feb42f9. |
luckysori
force-pushed
the
fix/duplicate-funding-rates
branch
from
fc36c9a to
23ac948
Compare
holzeis
reviewed
Jun 6, 2024
| @@ -39,6 +39,8 @@ pub fn insert_funding_rates( | |||
|
|
|||
| let affected_rows = diesel::insert_into(funding_rates::table) | |||
| .values(funding_rates) | |||
| .on_conflict(funding_rates::end_date) | |||
| .do_nothing() | |||
| .execute(conn)?; | |||
|
|
|||
| if affected_rows == 0 { | |||
There was a problem hiding this comment.
🤔 Maybe we don't want this either?
There was a problem hiding this comment.
I agree, I've removed it now :D
luckysori
force-pushed
the
fix/duplicate-funding-rates
branch
from
23ac948 to
b9ddf11
Compare
holzeis
approved these changes
Jun 6, 2024
We only need one funding rate entry per `end_date`. Without this change we were getting a new duplicate entry per maker restart. We `DO NOTHING` on conflict to ensure that the actually new rows in the batch will be inserted if we encounter any conflicts.
luckysori
force-pushed
the
fix/duplicate-funding-rates
branch
from
b9ddf11 to
d0e6b43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need one funding rate entry per
end_date.Without this change we were getting a new duplicate entry per maker restart.