Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Better task status dialogue #2625

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix: Better task status dialogue #2625

merged 1 commit into from
Jun 17, 2024

Conversation

Restioson
Copy link
Contributor

  • Don't show thin white pixel artifact around status dialog
  • Clamp size of dialogue so that it always shows the entire header image

Before:
image

After:
image

@holzeis
Copy link
Contributor

holzeis commented Jun 12, 2024

Looks good. Did you make sure it will also look good on the phone?

@Restioson
Copy link
Contributor Author

Looks good. Did you make sure it will also look good on the phone?

Looks great on my phone at least!

@Restioson Restioson enabled auto-merge June 13, 2024 13:42
@Restioson Restioson force-pushed the fix/better-status-dialog branch from db8e220 to 9347b95 Compare June 13, 2024 13:45
@Restioson Restioson requested a review from holzeis June 13, 2024 13:45
@Restioson
Copy link
Contributor Author

Force push was for formatting

@holzeis holzeis disabled auto-merge June 13, 2024 13:47
holzeis
holzeis reviewed Jun 13, 2024
View reviewed changes
mobile/lib/common/task_status_dialog.dart Outdated
);
double width = min((MediaQuery.of(context).size.width), 350);

logger.i(width);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 remove log

@Restioson Restioson force-pushed the fix/better-status-dialog branch from 9347b95 to 8257584 Compare June 13, 2024 14:14
@holzeis holzeis added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 49afd95 Jun 17, 2024
23 checks passed
@holzeis holzeis deleted the fix/better-status-dialog branch June 17, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holzeis holzeis holzeis approved these changes

Assignees

@Restioson Restioson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Restioson @holzeis