Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deserializing Events #4724

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Merge branch 'main' into feat/deserializing-events

4df6ad9
Select commit
Loading
Failed to load commit list.
Draft

feat: Deserializing Events #4724

Merge branch 'main' into feat/deserializing-events
4df6ad9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 23, 2025 in 1s

91.292% (+0.179%) compared to f5a9f3f

View this Pull Request on Codecov

91.292% (+0.179%) compared to f5a9f3f

Details

Codecov Report

Attention: Patch coverage is 99.58621% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.292%. Comparing base (f5a9f3f) to head (4df6ad9).

Files with missing lines Patch % Lines
...s/Swift/Protocol/Codable/DecodeArbitraryData.swift 95.774% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4724       +/-   ##
=============================================
+ Coverage   91.112%   91.292%   +0.179%     
=============================================
  Files          623       632        +9     
  Lines        72495     73221      +726     
  Branches     25785     26682      +897     
=============================================
+ Hits         66052     66845      +793     
+ Misses        6351      6279       -72     
- Partials        92        97        +5     
Files with missing lines Coverage Δ
Sources/Sentry/SentryGeo.m 95.000% <100.000%> (+1.000%) ⬆️
...ft/Protocol/Codable/NSNumberDecodableWrapper.swift 100.000% <100.000%> (ø)
Sources/Swift/Protocol/Codable/SentryCodable.swift 100.000% <100.000%> (ø)
...es/Swift/Protocol/Codable/SentryFrameCodable.swift 100.000% <100.000%> (ø)
...rces/Swift/Protocol/Codable/SentryGeoCodable.swift 100.000% <100.000%> (ø)
...ces/Swift/Protocol/Codable/SentryUserCodable.swift 100.000% <100.000%> (ø)
...tryTests/Protocol/Codable/ArbitraryDataTests.swift 100.000% <100.000%> (ø)
...otocol/Codable/NSNumberDecodableWrapperTests.swift 100.000% <100.000%> (ø)
...tryTests/Protocol/Codable/SentryCodableTests.swift 100.000% <100.000%> (ø)
Tests/SentryTests/Protocol/SentryFrameTests.swift 100.000% <100.000%> (ø)
... and 3 more

... and 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a9f3f...4df6ad9. Read the comment docs.