Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deserializing SentryFrame #4739

Merged
merged 13 commits into from
Jan 23, 2025

Conversation

philipphofmann
Copy link
Member

This PR is based on #4724.

Add Decodable/Deserializing of SentryFrame, including logic for decoding NSNumbers.

#skip-changelog

Copy link

github-actions bot commented Jan 21, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 46feb83

Copy link

github-actions bot commented Jan 21, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.46 ms 1251.52 ms 15.06 ms
Size 22.31 KiB 784.02 KiB 761.71 KiB

Baseline results on branch: feat/deserializing-events

Startup times

Revision Plain With Sentry Diff
04e8394 1223.24 ms 1244.33 ms 21.08 ms
8dae1f6 1212.60 ms 1226.52 ms 13.93 ms
8a562cc 1228.57 ms 1245.18 ms 16.60 ms

App size

Revision Plain With Sentry Diff
04e8394 22.31 KiB 771.93 KiB 749.62 KiB
8dae1f6 22.31 KiB 772.51 KiB 750.20 KiB
8a562cc 22.31 KiB 773.33 KiB 751.02 KiB

Previous results on branch: feat/deserializing-frame

Startup times

Revision Plain With Sentry Diff
62a81af 1223.14 ms 1237.64 ms 14.50 ms

App size

Revision Plain With Sentry Diff
62a81af 22.31 KiB 784.03 KiB 761.71 KiB

Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but need to add availability checks to the tests:

UInt128 is available starting with

  • macOS 15.0
  • iOS 18.0
  • watchOS 11.0
  • tvOS 18.0
  • visionOS 2.0

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.304%. Comparing base (7d4acb9) to head (46feb83).
Report is 5 commits behind head on feat/deserializing-events.

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##           feat/deserializing-events     #4739       +/-   ##
===============================================================
+ Coverage                     91.265%   91.304%   +0.038%     
===============================================================
  Files                            629       632        +3     
  Lines                          72919     73209      +290     
  Branches                       26587     26671       +84     
===============================================================
+ Hits                           66550     66843      +293     
+ Misses                          6272      6269        -3     
  Partials                          97        97               
Files with missing lines Coverage Δ
...ft/Protocol/Codable/NSNumberDecodableWrapper.swift 100.000% <100.000%> (ø)
...es/Swift/Protocol/Codable/SentryFrameCodable.swift 100.000% <100.000%> (ø)
...otocol/Codable/NSNumberDecodableWrapperTests.swift 100.000% <100.000%> (ø)
Tests/SentryTests/Protocol/SentryFrameTests.swift 100.000% <100.000%> (ø)

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4acb9...46feb83. Read the comment docs.

@philipphofmann philipphofmann merged commit aa9e313 into feat/deserializing-events Jan 23, 2025
63 of 65 checks passed
@philipphofmann philipphofmann deleted the feat/deserializing-frame branch January 23, 2025 07:47
@philipphofmann philipphofmann mentioned this pull request Jan 23, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants