-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deserializing SentryFrame #4739
feat: Deserializing SentryFrame #4739
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
04e8394 | 1223.24 ms | 1244.33 ms | 21.08 ms |
8dae1f6 | 1212.60 ms | 1226.52 ms | 13.93 ms |
8a562cc | 1228.57 ms | 1245.18 ms | 16.60 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
04e8394 | 22.31 KiB | 771.93 KiB | 749.62 KiB |
8dae1f6 | 22.31 KiB | 772.51 KiB | 750.20 KiB |
8a562cc | 22.31 KiB | 773.33 KiB | 751.02 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but need to add availability checks to the tests:
UInt128 is available starting with
- macOS 15.0
- iOS 18.0
- watchOS 11.0
- tvOS 18.0
- visionOS 2.0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/deserializing-events #4739 +/- ##
===============================================================
+ Coverage 91.265% 91.304% +0.038%
===============================================================
Files 629 632 +3
Lines 72919 73209 +290
Branches 26587 26671 +84
===============================================================
+ Hits 66550 66843 +293
+ Misses 6272 6269 -3
Partials 97 97
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
aa9e313
into
feat/deserializing-events
This PR is based on #4724.
Add Decodable/Deserializing of SentryFrame, including logic for decoding NSNumbers.
#skip-changelog