Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ActivityLifecycleSpanHelperTest by resetting AppStartMetrics #4038

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

adinauer
Copy link
Member

#skip-changelog

📜 Description

Fix ActivityLifecycleSpanHelperTest by resetting AppStartMetrics

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4cb6851

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 385.02 ms 439.86 ms 54.84 ms
Size 1.65 MiB 2.31 MiB 677.51 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
00c8eeb 415.32 ms 428.08 ms 12.76 ms

App size

Revision Plain With Sentry Diff
00c8eeb 1.70 MiB 2.36 MiB 671.98 KiB

Previous results on branch: feat/fix-activity-lifecycle-span-helper-test

Startup times

Revision Plain With Sentry Diff
a2ee75b 401.30 ms 466.69 ms 65.39 ms

App size

Revision Plain With Sentry Diff
a2ee75b 1.65 MiB 2.31 MiB 677.51 KiB

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@adinauer adinauer merged commit 02442c0 into main Jan 10, 2025
38 checks passed
@adinauer adinauer deleted the feat/fix-activity-lifecycle-span-helper-test branch January 10, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants