Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use java.net.URL for combining url attributes #4105

Open
wants to merge 1 commit into
base: feat/otel-server-request-headers
Choose a base branch
from

Conversation

adinauer
Copy link
Member

#skip-changelog

📜 Description

Use java.net.URL for combining url attributes

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f692945

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 385.75 ms 455.06 ms 69.31 ms
Size 1.65 MiB 2.31 MiB 677.61 KiB

Baseline results on branch: feat/otel-server-request-headers

Startup times

Revision Plain With Sentry Diff
01d4a6e 408.89 ms 451.35 ms 42.45 ms

App size

Revision Plain With Sentry Diff
01d4a6e 1.65 MiB 2.31 MiB 677.61 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants