Use GNOME 46 in weekly flatpak #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to getting-things-gnome#708 This fixes the following error: ``` $ flatpak install org.gnome.GTG.Devel_20240530.flatpak error: The application org.gnome.GTG.Devel/x86_64/master requires the runtime org.gnome.Platform/x86_64/master which was not found ``` by using the latest GNOME runtime, as opposed to the "master" one, which doesn't seem to exist. Tested by running the workflow on my fork, downloading the artifact from GHA, installing and running the flatpak.
SqAtx
commented
Jul 4, 2024
| @@ -12,11 +12,11 @@ jobs: | |||
| # again | |||
| runs-on: ubuntu-24.04 | |||
| container: | |||
| image: bilelmoussaoui/flatpak-github-actions:gnome-nightly | |||
| image: bilelmoussaoui/flatpak-github-actions:gnome-46 | |||
There was a problem hiding this comment.
This isn't strictly necessary. We could use nightly. I just figured this would be more stable, and it's okay if we lag behind a bit after new GNOME releases.
There was a problem hiding this comment.
True, we can update every now and then
|
LGTM! |
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #708
This fixes the following error:
by using the latest GNOME runtime, as opposed to the "master" one, which doesn't seem to exist.
Tested by running the workflow on my fork, downloading the artifact from GHA, installing and running the flatpak.