Tests and a fix for BaseStore.parent #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add unit tests for BaseStore.parent - ensure that the store is unchanged when called with invalid IDs - add helpful error messages to the exceptions
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
diegogangl
added
bug
enhancement
maintainability
|
Ah that was before I understood the importance of keeping try/excepts 1-line long :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote unit tests for
BaseStore.parent. The tests revealed that calling the method with a non-existingparent_idchanges the list of root elements (self.data).The main changes are as follows:
BaseStore.parent,