Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export plugin: Make it clickable in the menu #370

Merged

Conversation

Neui
Copy link
Contributor

@Neui Neui commented Jun 19, 2020

Looks like since the GTK3 Headerbar switch, the new menus use ModelButtons instead of the old MenuItems.
Fixes the comment by nekohayo in #299.

Found using the GTK Inspector (Ctrl+Shift+i doesn't work for some reason, I used GTK_DEBUG=interactive ./launch.sh: (The export plugins menu entry is called "Exportiere die aktuell gelistete Aufgaben" here)
Image of the GTK Inspector showing the button being GtkMenuItem instead of GtkModelButton like the others

Note that the plugin itself seems to be buggy, I couldn't export anything (to check what it really exports, like does it take into account the current filter being applied?)
When trying to export (using the open button), I just get an error message that the document couldn't be exported, and a reason is some python error, so there is still debugging to be done.
Possibly remove the plugin temporarily for the upcoming release, if there isn't enough time.

(BTW the "open" string when exporting conflicts with the "open" (view) string in the main window for the open tasks; There is an distinction in german, I would likely make an PR or Issue to mark the "open" (view) string in the main window specially, so it has its own translation)

Looks like since the GTK3 Headerbar switch, the new menus use
ModelButtons instead of the old MenuItems.
@diegogangl diegogangl merged commit b3ba63e into getting-things-gnome:master Jun 20, 2020
@diegogangl
Copy link
Contributor

Thanks, merged. We'll probably include this plugin for this version and then move on to the new one (whenever it's done) for 0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants