Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billing #36

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Billing #36

merged 3 commits into from
Mar 7, 2024

Conversation

sckott
Copy link
Member

@sckott sckott commented Mar 6, 2024

#28

Thoughts @seankross ?

In particular:

  • two exported fxns: aws_billing and aws_billing_raw (not a great fxn name)
  • a vignette for billing showing a few plots
  • a mapping service_map to map super long AWS service names to acronyms that folks can use for plotting, etc.

@sckott sckott requested a review from seankross March 6, 2024 23:53
@seankross
Copy link
Collaborator

two exported fxns: aws_billing and aws_billing_raw (not a great fxn name)

From our perspective it's not a great name but I actually think our users will like it, they say they want the raw data, we're giving it to them!

a vignette for billing showing a few plots

This is really nice, thank you.

a mapping service_map to map super long AWS service names to acronyms that folks can use for plotting, etc.

This is such a nice quality of life feature, thanks so much for thinking to do this.

@sckott
Copy link
Member Author

sckott commented Mar 7, 2024

Thanks for having a look. Do point out changes you think would be good after merging.

@sckott sckott added this to the v0.1 milestone Mar 7, 2024
@sckott sckott merged commit 33bcced into main Mar 7, 2024
0 of 7 checks passed
@sckott sckott deleted the billing branch March 7, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants