Secrets and vpcs #37
Merged
Secrets and vpcs #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it'd be nice if you could look over this sooner than later because the other part of the broken up PR depends on the code in this PR. thanks! |
seankross
approved these changes
Mar 7, 2024
|
great,thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29
this is 1 of 2 new PRs breaking apart PR #32
@seankross hopefully this is more straightforward to review - we didn't have interfaces to these services as a high priority but these seem really good to have nonetheless - and whether or not we get IAM route working for RDS, I think we still might need to do secretsmanager stuff