Add scanpy #25
Add scanpy #25
Conversation
There was a problem hiding this comment.
First off, holy crap, really sorry it took me so long to re-review... 🤦♂️ Those updates to pip look awesome, thanks for updating those. One last thing to update though, just for WILDS-style purposes, mind adding the tag to the filenames? (see comments for details).
|
No worries at all. I have changed the Dockerfile names and updated package version as well! |
There was a problem hiding this comment.
Interesting update! Yesterday, I noticed that the linter GitHub Action wasn't performing its check, turns out we've recently added some security features in WILDS to restrict which action types are allowed. Just needed to add the hadolint action to the list of acceptable actions and it ran as expected on the next push.
That being said, you'll now notice that the check failed because of a few small optimization issues with scvi-tools (follow link or see screenshot below). Mind fixing these as well? Happy to chat Monday to go through these as well!
|
I have made the following changes to scvi-tools: cbaf540
|
There was a problem hiding this comment.
Found one last issue. I tried building both images locally and the scvi-tools image errored out. Looks like combining the two pip calls threw things off because of the --index-url argument. I just split it into two pip calls again, but on the same RUN command, compiled fine from there. Thanks for your hard work and patience on this Sanaz! 🥳
Description
Related Issue
Example