Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support buildOptional and buildEither #10

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Support buildOptional and buildEither #10

merged 4 commits into from
Jul 11, 2024

Conversation

Kuniwak
Copy link
Contributor

@Kuniwak Kuniwak commented Jul 9, 2024

My motivation is explained in #8.

@Kuniwak Kuniwak mentioned this pull request Jul 9, 2024
Closed
gh123man
gh123man requested changes Jul 9, 2024
View reviewed changes
Copy link
Owner

@gh123man gh123man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and writing tests - just some very minor comments.

Tests/AsyncChannelsTests/AsyncChannelTests.swift Show resolved Hide resolved
Tests/AsyncChannelsTests/AsyncChannelTests.swift Outdated Show resolved Hide resolved
@Kuniwak Kuniwak requested a review from gh123man July 10, 2024 21:22
gh123man
gh123man approved these changes Jul 11, 2024
View reviewed changes
Copy link
Owner

@gh123man gh123man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Ill get these published in the next release soon.

@gh123man gh123man merged commit 37d32cf into gh123man:main Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gh123man gh123man gh123man approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kuniwak @gh123man