Allow adding multiple space-separated classes for openClass
#382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this library - great solution for us and really lightweight!
Small suggestion here - to allow passing multiple classes to
openClass
config option.This would be useful to pass modifier classes such as
modal--s
for small modal content for eg:Solution splits this space-separated string into a comma-separated array that we spread into
add()
andremove()
.A long term solution might be to have something like
openClasses
as the param and the ability to pass an array of classes here rather than a string.Thanks!
PS. Untested in the lib as I'm still setting it up and might break your Cypress tests for now. Will update if you're interested in this suggestion and when I've set up the project 👍