Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add live user with specific UID of 1100 #205

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

ghost
Copy link

@ghost ghost commented Sep 10, 2024

  • Updated the user creation script to assign the live user a specific UID (1100). This ensures consistency in the user ID for the installed environment.

Summary by Sourcery

Enhance the user creation script by assigning a specific UID (1100) to the live user to ensure consistent user ID across installations.

Enhancements:

  • Assign a specific UID (1100) to the live user in the user creation script to ensure consistency in the user ID for the installed environment.

- Updated the user creation script to assign the live user a specific UID (1100). This ensures consistency in the user ID for the installed environment.
@ghost ghost requested review from a team as code owners September 10, 2024 23:31
Copy link
Contributor

sourcery-ai bot commented Sep 10, 2024

Reviewer's Guide by Sourcery

This pull request modifies the user creation script to assign a specific UID (1100) to the live user. The change is implemented by adding the '-u 1100' option to the 'pw useradd' command in the setuser.sh script.

File-Level Changes

Change Details Files
Assign specific UID to live user
  • Add '-u 1100' option to 'pw useradd' command
  • Ensure consistency in user ID for installed environment
common_config/setuser.sh

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vimanuelt - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you add a comment in the script explaining why the UID 1100 was chosen? This would help future maintainers understand the rationale behind this decision.
  • Have you considered potential conflicts with existing systems that might already use UID 1100? It might be worth mentioning any considerations or checks performed to ensure this won't cause issues.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link
Member

@ericbsd ericbsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericbsd ericbsd merged commit 5db883b into ghostbsd:master Sep 10, 2024
2 checks passed
@ericbsd ericbsd assigned ericbsd and ghost and unassigned ericbsd Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant