Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed automount related code. #208

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Removed automount related code. #208

merged 1 commit into from
Jan 21, 2025

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Jan 21, 2025

It is removed from the default installation.

Summary by Sourcery

Remove automounting support from the default installation.

Enhancements:

  • Remove automount configuration files.

Chores:

  • Disable automounting on boot.

@ericbsd ericbsd self-assigned this Jan 21, 2025
@ericbsd ericbsd requested review from a team as code owners January 21, 2025 01:33
@ericbsd ericbsd added the bug label Jan 21, 2025
Copy link
Contributor

sourcery-ai bot commented Jan 21, 2025

Reviewer's Guide by Sourcery

This pull request removes the automount configuration from the default installation.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed automount configuration files.
  • Removed the lines that rename the automount configuration files to *.skip.
build.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide a more detailed commit message explaining why automount was removed from the default installation and what the expected behavior is now.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericbsd ericbsd merged commit 4c2aad0 into master Jan 21, 2025
2 checks passed
@ericbsd ericbsd deleted the remove-automoun-code branch January 21, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant