Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing set_date function #494

Closed
wants to merge 5 commits into from
Closed

Conversation

edo2313
Copy link

@edo2313 edo2313 commented Mar 27, 2024

As written in this comment, a date variable is the number of days since 1990-01-01, written as a int.
I can't test it right now, but it's really simple so there shouldn't be any problems...

Copy link
Contributor

@nikteliy nikteliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I like the detailed docstring with examples. However, it seems that the code needs some improvement; it currently doesn't work as expected. It would be great if you could also add a couple of tests to your pull request.

snap7/util.py Outdated Show resolved Hide resolved
snap7/util.py Show resolved Hide resolved
@edo2313 edo2313 requested a review from nikteliy March 28, 2024 12:02
pyproject.toml Outdated Show resolved Hide resolved
@edo2313 edo2313 requested a review from gijzelaerr April 9, 2024 14:26
gijzelaerr added a commit that referenced this pull request May 2, 2024
@gijzelaerr
Copy link
Owner

manually merged here d27e373

thanks!

@gijzelaerr gijzelaerr closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants