Improve typing #516
Merged
Improve typing #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikteliy
force-pushed
the
improve_typing
branch
2 times, most recently
from
7c6f21e to
cbd2bfe
Compare
|
This PR will break python 3.8 usage (again). |
nikteliy
force-pushed
the
improve_typing
branch
3 times, most recently
from
60881b1 to
1662069
Compare
nikteliy
force-pushed
the
improve_typing
branch
3 times, most recently
from
21b133f to
3741002
Compare
and again the answer is that we dropped support for <=3.8 |
gijzelaerr
requested changes
May 30, 2024
nikteliy
force-pushed
the
improve_typing
branch
4 times, most recently
from
3a96d04 to
ccefa63
Compare
gijzelaerr
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--strictparameter to mypy in pre-commit.conf