Lora acknowledgement zero response fix #434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gioblu,
I've been using a small network of devices using PJON Through LoRa for the past few years and have started work on a remote gate monitor / doorbell that requires acknowledgement. This pull request fixes a bug where response packets were all zeros and adds an optional delay between receiving a packet and acknowledging it due to the extremely slow microcontrollers on the other end of the system.
Responses being all zeros
The call to
prepare_responseon line 175 passed the address of the end of the frame rather than the start of the frame.Response delay
This is a feature that doesn't have to be merged, but I found to be required by my system that is not using the official library on the other end of the connection. The delay is disabled by default.