feat: add ShareUrlButton functionality #823
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gisce/webclient#1612 - Introduced ShareUrlButton and ActionBarSeparator components across DashboardActionBar, FormActionBar, GraphActionBar, and TreeActionBar for improved UI consistency. - Updated locale files (ca_ES, en_US, es_ES) to include new translations for sharing functionality. - Enhanced type definitions to support action_id and action_type in view data structures.
gisce/webclient#1612 - Refactored the copyToClipboard function to use a temporary textarea for better compatibility across browsers and avoid SSL restrictions - Updated the ShareUrlButton component to include new icons and improved styling. - Added new translations for "Copy to clipboard" in ca_ES, en_US, and es_ES locale files. - Adjusted the popover content padding for a cleaner UI.
gisce/webclient#1612 - Updated GraphActionBar to accept a new optional `domain` prop for improved functionality. - Modified ShareUrlButton to utilize the `domain` prop, allowing for better sharing context. - Refactored TreeActionBar to compute `finalDomain` using `useMemo`, optimizing performance. - Adjusted share URL creation in shareUrlHelper to include `domain` in the URL parameters if provided. - Updated GraphActionView to pass the merged `domain` to GraphActionBar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/gisce/webclient/issues/1612