Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add guidance on security implications for forks #232

Merged
merged 5 commits into from
Sep 10, 2024
Merged

docs: add guidance on security implications for forks #232

merged 5 commits into from
Sep 10, 2024

Conversation

wrslatz
Copy link
Contributor

@wrslatz wrslatz commented Sep 6, 2024

Pull Request

Proposed Changes

Document security considerations for contributions through PMA once they are synced to a public fork.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run npm run lint and fix any linting issues that have been introduced
  • run npm run test and run tests
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

@wrslatz
docs: add security implications for public forks
2ba0e28
@wrslatz
chore: fix format for list images in usage guide
3ebb1c2 
Indent the images in the usage guide lists so that the images are nested
under the list item rather than breaking the list
@wrslatz wrslatz requested a review from a team as a code owner September 6, 2024 18:04
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 6, 2024
coffeesippa
coffeesippa approved these changes Sep 9, 2024
View reviewed changes
Copy link

@coffeesippa coffeesippa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this guidance to the documentation.

docs/using-the-app.md Outdated Show resolved Hide resolved
ajhenry
ajhenry approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@ajhenry ajhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks for the contribution! ❤️

ahpook
ahpook approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks @wrslatz !

ahpook
ahpook approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple copy-edits to remove the passive voice in line with our style guide, but this is great, thanks so much for the additions @wrslatz !

docs/using-the-app.md Outdated Show resolved Hide resolved
docs/using-the-app.md Outdated Show resolved Hide resolved
docs/using-the-app.md Outdated Show resolved Hide resolved
@ahpook ahpook merged commit f408e47 into github-community-projects:main Sep 10, 2024
6 checks passed
@wrslatz wrslatz deleted the fork-security-guidance branch September 10, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajhenry ajhenry ajhenry approved these changes

@coffeesippa coffeesippa coffeesippa approved these changes

@ahpook ahpook ahpook approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wrslatz @ahpook @coffeesippa @ajhenry