Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create mirror error handling overwriting initial error #301

Conversation

riley-kohler
Copy link
Contributor

@riley-kohler riley-kohler commented Jan 21, 2025

Pull Request

Proposed Changes

Replaces the current nested error handling with an if inside the outer error handler that checks if the mirror repo has already been created before attempting to delete it on failure.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run npm run lint and fix any linting issues that have been introduced
  • run npm run test and run tests
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

@riley-kohler riley-kohler merged commit bed6b25 into github-community-projects:main Jan 21, 2025
9 checks passed
@riley-kohler riley-kohler deleted the fix_create_mirror_error_handling_overwriting_initial_error branch January 21, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants