put output channel button in cell toolbar

README.md

@@ -189,7 +189,7 @@ tried it.
 
 Standard output and error streams are captured when running cells and sent to a
 per-cell output channel. Press the ![output](./assets/CodiconOutput.svg) button
-in the cell status bar to view the channel.
+in the cell toolbar to view the channel.
 
 ## Environment variables
 

packages/vscode/package.json

@@ -36,6 +36,13 @@
         "category": "Vitale",
         "icon": "$(open-preview)",
         "enablement": "notebookType == 'vitale-notebook' && notebookCellHasOutputs"
+      },
+      {
+        "title": "Show cell output channel",
+        "command": "vitale.showCellOutputChannel",
+        "category": "Vitale",
+        "icon": "$(output)",
+        "enablement": "notebookType == 'vitale-notebook'"
       }
     ],
     "menus": {
@@ -54,8 +61,13 @@
       "notebook/cell/title": [
         {
           "command": "vitale.viewCellOutputInPane",
-          "group": "inline/cell",
+          "group": "inline/cell@1",
           "when": "notebookType == 'vitale-notebook' && notebookCellHasOutputs"
+        },
+        {
+          "command": "vitale.showCellOutputChannel",
+          "group": "inline/cell@2",
+          "when": "notebookType == 'vitale-notebook'"
         }
       ]
     },

packages/vscode/src/cellStatusBarItemProvider.ts

@@ -42,20 +42,6 @@ export class NotebookCellStatusBarItemProvider
     };
     items.push(pauseItem);
 
-    // TODO(jaked)
-    // it would be nice to show this only if there is any output
-    const stdoutItem = new vscode.NotebookCellStatusBarItem(
-      "$(output)",
-      vscode.NotebookCellStatusBarAlignment.Right
-    );
-    stdoutItem.tooltip = "Stdout";
-    stdoutItem.command = {
-      title: "Show stdout",
-      command: "vitale.showStdout",
-      arguments: [cell],
-    };
-    items.push(stdoutItem);
-
     return items;
   }
 }

packages/vscode/src/extension.ts

@@ -5,7 +5,7 @@ import { makeHandleDidChangeNotebookDocument } from "./handleDidChangeNotebookDo
 import { makeHandleDidChangeNotebookEditorSelection } from "./handleDidChangeNotebookEditorSelection";
 import { handleDidChangeTextDocument } from "./handleDidChangeTextDocument";
 import { pauseCell } from "./pauseCell";
-import { showStdout } from "./showStdout";
+import { showCellOutputChannel } from "./showCellOutputChannel";
 import { NotebookSerializer } from "./serializer";
 import { CellOutputPanes } from "./cellOutputPanes";
 
@@ -34,7 +34,10 @@ export function activate(context: vscode.ExtensionContext) {
       vscode.env.clipboard.writeText(s);
     }),
     vscode.commands.registerCommand("vitale.pauseCell", pauseCell),
-    vscode.commands.registerCommand("vitale.showStdout", showStdout),
+    vscode.commands.registerCommand(
+      "vitale.showCellOutputChannel",
+      showCellOutputChannel
+    ),
     vscode.commands.registerCommand(
       "vitale.viewCellOutputInPane",
       cellOutputPanes.makeViewCellOutputInPane()

packages/vscode/src/showStdout.ts → packages/vscode/src/showCellOutputChannel.ts

@@ -1,6 +1,9 @@
 import * as vscode from "vscode";
 
-export const showStdout = async (cell: vscode.NotebookCell) => {
+export const showCellOutputChannel = async (cell?: vscode.NotebookCell) => {
+  if (!cell) {
+    return;
+  }
   const name = `${cell.notebook.uri.fsPath}-${cell.metadata.id}-stdout`;
   const channel = vscode.window.createOutputChannel(name, { log: true });
   channel.show(/* preserveFocus: */ true);