don't skip execution for empty cells

fixes #47 I think this was code leftover from a refactor (at one point I wanted to trigger execution for dependent cells without taking unsubmitted cell contents).
githubnext · Jul 22, 2024 · d5e4a46 · d5e4a46
1 parent af640ff
commit d5e4a46
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/server/src/client.ts b/packages/server/src/client.ts
@@ -34,7 +34,7 @@ export class Client {
       path: string;
       cellId: string;
       language: string;
-      code?: string;
+      code: string;
     }[],
     force: boolean,
     executeDirtyCells: boolean
@@ -44,9 +44,7 @@ export class Client {
     for (const { path, cellId, language, code } of cells) {
       const ext = extOfLanguage(language);
       const id = `${path}-cellId=${cellId}.${ext}`;
-      if (code) {
-        this.cells.set(id, { cellId, code, language });
-      }
+      this.cells.set(id, { cellId, code, language });
 
       this.runtime.invalidateServerModule(id);
       this.runtime.handleHMRUpdate(id);

diff --git a/packages/server/src/rpc-types.ts b/packages/server/src/rpc-types.ts
@@ -25,7 +25,7 @@ export type ServerFunctions = {
       path: string;
       cellId: string;
       language: string;
-      code?: string;
+      code: string;
     }[],
     force: boolean,
     executeDirtyCells: boolean