avoid RPC loop when there are no cells to execute / dirty

githubnext · Apr 18, 2024 · f0ba51b · f0ba51b
1 parent 2247ffe
commit f0ba51b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/packages/server/src/server.ts b/packages/server/src/server.ts
@@ -257,6 +257,9 @@ class VitaleDevServer {
   }
 
   private markCellsDirty(cells: { path: string; cellId: string }[]) {
+    if (cells.length === 0) {
+      return;
+    }
     for (const client of this.clients.values()) {
       client.markCellsDirty(cells);
     }

diff --git a/packages/vscode/src/controller.ts b/packages/vscode/src/controller.ts
@@ -359,6 +359,9 @@ export class NotebookController {
   }
 
   private async executeCells(notebookCells: vscode.NotebookCell[]) {
+    if (notebookCells.length === 0) {
+      return;
+    }
     const cells = notebookCells.map((cell) => ({
       path: cell.notebook.uri.fsPath,
       cellId: cell.metadata.id,