Adds Open tag on remote option to tagView #3768

nzaytsev · 2024-11-18T10:34:09Z

Description

Checklist

I have followed the guidelines in the Contributing document
My changes follow the coding style of this project
My changes build without any errors or warnings
My changes have been formatted and linted
My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

eamodio

Please ensure this follows the patterns of "commits"

eamodio · 2024-11-19T05:55:45Z

package.json

@@ -3668,7 +3668,8 @@
 										"fileInCommit",
 										"fileInBranch",
 										"fileLine",
-										"fileRange"
+										"fileRange",
+										"tagName"


Rename to tag to match branch, commit, etc

eamodio · 2024-11-19T05:56:17Z

package.json

@@ -3706,6 +3707,10 @@
 										"fileRange": {
 											"type": "string",
 											"markdownDescription": "Specifies the format of a range in a file URL for the custom remote service\n\nAvailable tokens\\\n`${start}` &mdash; starting line\\\n`${end}` &mdash; ending line"
+										},
+										"tagName": {


Rename to tag

eamodio · 2024-11-19T05:57:36Z

package.json

@@ -6752,6 +6757,12 @@
 				"title": "Open Commit on Remote",
 				"icon": "$(globe)"
 			},
+			{


Add a gitlens.openTagOnRemote command like commit/branch/etc for access from the Command Palette

Should also not be placed in the middle of the commit commands, put it after

eamodio · 2024-11-19T05:59:50Z

package.json

+					"command": "gitlens.views.openTagOnRemote",
+					"when": "gitlens:repos:withRemotes && viewItem =~ /gitlens:tag\\b(.*?\\b\\+remote\\b)/",
+					"group": "inline@99"
+				},


Add a gitlens.views.copyRemoteTagUrl command and add it as an alt, like commit

Needs to also follow the commit[s] pattern to add this to the context menu as well

eamodio · 2024-11-19T06:00:22Z

src/config.ts

@@ -580,6 +580,7 @@ export interface RemotesUrlsConfig {
 	readonly fileInCommit: string;
 	readonly fileLine: string;
 	readonly fileRange: string;
+	readonly tag: string;


This is correct once tagName is renamed above

eamodio · 2024-11-19T06:01:00Z

src/git/remotes/custom.ts

@@ -100,6 +100,10 @@ export class CustomRemote extends RemoteProvider {
 		return url;
 	}

+	protected override getUrlForTag(tagName: string): string {
+		return this.getUrl(this.urls.tag, this.getContext({ tagName: tagName }));


Rename to tag

eamodio · 2024-11-19T06:01:27Z

src/git/remotes/gerrit.ts

@@ -191,4 +191,8 @@ export class GerritRemote extends RemoteProvider {
 		if (branch) return `${this.encodeUrl(`${this.getUrlForBranch(branch)}/${fileName}`)}${line}`;
 		return `${this.encodeUrl(`${this.baseUrl}/+/HEAD/${fileName}`)}${line}`;
 	}
+
+	protected override getUrlForTag(): string | undefined {
+		return undefined;


Is there no support for tags?

There is no tag details view for gerrit, only tags list view

eamodio · 2024-11-19T06:04:53Z

src/views/nodes/tagsNode.ts

@@ -33,13 +34,20 @@ export class TagsNode extends CacheableChildrenViewNode<'tags', ViewsWithTagsNod
 	}

 	async getChildren(): Promise<ViewNode[]> {
+		const remote = await this.repo.git.getBestRemoteWithProvider();


Why is this outside the if below?

moved inside

eamodio · 2024-11-19T06:08:32Z

package.json

+				"title": "Open Tag on Remote",
+				"category": "GitLens",
+				"icon": "$(globe)"
+			},


Should also add gitlens.views.openTagOnRemote.multi command to follow the pattern of commit[s]

nzaytsev · 2025-01-16T08:58:56Z

closed in favor #3937

nzaytsev linked an issue Nov 18, 2024 that may be closed by this pull request

open github release note page from tag #3711

Open

nzaytsev requested review from eamodio and axosoft-ramint November 18, 2024 10:34

eamodio requested changes Nov 19, 2024

View reviewed changes

nzaytsev requested a review from eamodio November 20, 2024 14:24

axosoft-ramint removed their request for review December 4, 2024 22:50

Adds Open tag on remote option to tagView

a81685c

nzaytsev force-pushed the features/3711-open-github-release-note-page-from-tag branch from ba92943 to a81685c Compare January 16, 2025 07:26

nzaytsev closed this Jan 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds Open tag on remote option to tagView #3768

Adds Open tag on remote option to tagView #3768

nzaytsev commented Nov 18, 2024 •

edited

Loading

eamodio left a comment

eamodio Nov 19, 2024

nzaytsev Nov 19, 2024

eamodio Nov 19, 2024

nzaytsev Nov 19, 2024

eamodio Nov 19, 2024

eamodio Nov 19, 2024

eamodio Nov 19, 2024

eamodio Nov 19, 2024

eamodio Nov 19, 2024

eamodio Nov 19, 2024

nzaytsev Nov 19, 2024

eamodio Nov 19, 2024

nzaytsev Nov 19, 2024

eamodio Nov 19, 2024

nzaytsev Nov 19, 2024

eamodio Nov 19, 2024

nzaytsev Nov 19, 2024

nzaytsev commented Jan 16, 2025

Adds Open tag on remote option to tagView #3768

Adds Open tag on remote option to tagView #3768

Conversation

nzaytsev commented Nov 18, 2024 • edited Loading

Description

Checklist

eamodio left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nzaytsev commented Jan 16, 2025

nzaytsev commented Nov 18, 2024 •

edited

Loading