Integrations support self hosted providers from gkdev (#3901) #3922

sergeibbb · 2025-01-13T14:25:42Z

Description

#3901

Checklist

I have followed the guidelines in the Contributing document
My changes follow the coding style of this project
My changes build without any errors or warnings
My changes have been formatted and linted
My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

(#3901, #3922)

sergeibbb · 2025-01-13T15:13:16Z

@eamodio, @axosoft-ramint, @d13,

To sum up what is happening here: new type of integration "cloud-github-enterprise" that works as enterprise but gets authorization as cloud.

(#3901, #3922)

eamodio

Overall it looks good - though I did have a few questions.

src/constants.integrations.ts

src/git/parsers/remoteParser.ts

src/webviews/home/homeWebview.ts

src/git/remotes/remoteProviders.ts

(#3901, #3922)

eamodio · 2025-01-15T05:29:58Z

src/plus/integrations/authentication/integrationAuthentication.ts

 	}

 	protected async writeSecret(
 		key: IntegrationAuthenticationKeys,
 		session: ProviderAuthenticationSession | StoredSession,
 	) {
 		await this.container.storage.storeSecret(key, JSON.stringify(session));
+		await this.authenticationService.addConfigured({
+			integrationId: this.authProviderId,
+			domain: isSelfHostedIntegrationId(this.authProviderId) ? session.id : undefined,


This scares me a since we could in the future change the session.id to be/mean something else and we'd implicitly break this.

I would suggest we add domain on to the session like we are doing with cloud to make it explicit.

That's a good idea, though we would want to include a migration for existing sessions to include that like we did with cloud. @sergeibbb

@eamodio I'm going to add a TODO here and write this up as post-release debt

src/plus/integrations/authentication/models.ts

src/constants.storage.ts

eamodio · 2025-01-15T05:45:50Z

src/plus/integrations/authentication/integrationAuthentication.ts

 		await this.container.storage.deleteSecret(key);
+		await this.authenticationService.removeConfigured({
+			integrationId: this.authProviderId,
+			domain: isSelfHostedIntegrationId(this.authProviderId) ? sessionId : undefined,
+		});


Nit for another day, but it feels like these operations should be combined into the AuthService rather than in the base class.

src/plus/integrations/integrationService.ts

axosoft-ramint · 2025-01-15T14:58:16Z

@sergeibbb Please feel free to take over from here including @eamodio 's review comments on my "configured integrations" changes.

src/plus/integrations/integrationService.ts

(#3901, #3922)

sergeibbb linked an issue Jan 13, 2025 that may be closed by this pull request

Integrations: support self-hosted providers from gkdev #3901

Closed

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Adds support for GKDev Cloud GitHub Enterprise integration

9ea6153

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Associates a Cloud GitHub Enterprise provider with remote by its domain

d96fa7f

(#3901, #3922)

sergeibbb force-pushed the 3901-integrations-support-self-hosted-providers-from-gkdev branch from ede3ded to f00ba5b Compare January 13, 2025 14:28

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Adds GitHub Enterprize menu item

18e3d01

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Changes order of GitHub.com and GitHub Enterprise in the dropdown list

8c6c5c0

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Filters out GitHub's icon in the bar

c7d5292

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Makes sure that cloud version of GitHubEnterprise is used when needed

f00ba5b

(#3901, #3922)

sergeibbb requested review from axosoft-ramint, d13 and eamodio January 13, 2025 14:28

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Adds support for GKDev Cloud GitHub Enterprise integration

0879e85

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Associates a Cloud GitHub Enterprise provider with remote by its domain

31e969c

(#3901, #3922)

sergeibbb force-pushed the 3901-integrations-support-self-hosted-providers-from-gkdev branch from f00ba5b to b15b070 Compare January 13, 2025 17:06

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Adds GitHub Enterprize menu item

72d3c2d

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Changes order of GitHub.com and GitHub Enterprise in the dropdown list

e34a903

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Filters out GitHub's icon in the bar

4a285c0

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Makes sure that cloud version of GitHubEnterprise is used when needed

b15b070

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Adds support for GKDev Cloud GitHub Enterprise integration

5622e88

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Associates a Cloud GitHub Enterprise provider with remote by its domain

03f53c8

(#3901, #3922)

sergeibbb force-pushed the 3901-integrations-support-self-hosted-providers-from-gkdev branch from b15b070 to fb6f815 Compare January 13, 2025 17:07

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Adds GitHub Enterprize menu item

3025cc6

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Changes order of GitHub.com and GitHub Enterprise in the dropdown list

21947fa

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Filters out GitHub's icon in the bar

32bb670

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 13, 2025

Makes sure that cloud version of GitHubEnterprise is used when needed

fb6f815

(#3901, #3922)

eamodio approved these changes Jan 14, 2025

View reviewed changes

sergeibbb added a commit that referenced this pull request Jan 14, 2025

Adds support for GKDev Cloud GitHub Enterprise integration

a6c7542

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 14, 2025

Associates a Cloud GitHub Enterprise provider with remote by its domain

221cdef

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 14, 2025

Adds GitHub Enterprize menu item

423bcc0

(#3901, #3922)

axosoft-ramint pushed a commit that referenced this pull request Jan 14, 2025

Adds GitHub Enterprize menu item

fb4f293

(#3901, #3922)

axosoft-ramint pushed a commit that referenced this pull request Jan 14, 2025

Changes order of GitHub.com and GitHub Enterprise in the dropdown list

a92091a

(#3901, #3922)

axosoft-ramint pushed a commit that referenced this pull request Jan 14, 2025

Filters out GitHub's icon in the bar

ffd383e

(#3901, #3922)

axosoft-ramint force-pushed the 3901-integrations-support-self-hosted-providers-from-gkdev branch from cfaf38c to 15c7e7f Compare January 14, 2025 22:40

axosoft-ramint pushed a commit that referenced this pull request Jan 14, 2025

Makes sure that cloud version of GitHubEnterprise is used when needed

b337218

(#3901, #3922)

eamodio reviewed Jan 15, 2025

View reviewed changes

src/plus/integrations/authentication/models.ts Outdated Show resolved Hide resolved

eamodio reviewed Jan 15, 2025

View reviewed changes

src/constants.storage.ts Outdated Show resolved Hide resolved

eamodio reviewed Jan 15, 2025

View reviewed changes

src/plus/integrations/integrationService.ts Show resolved Hide resolved

axosoft-ramint reviewed Jan 15, 2025

View reviewed changes

src/plus/integrations/integrationService.ts Show resolved Hide resolved

sergeibbb and others added 7 commits January 15, 2025 18:47

Adds support for GKDev Cloud GitHub Enterprise integration

20fcac0

(#3901, #3922)

Associates a Cloud GitHub Enterprise provider with remote by its domain

9e7f282

(#3901, #3922)

Adds GitHub Enterprize menu item

0383223

(#3901, #3922)

Filters out GitHub's icon in the bar

920c654

(#3901, #3922)

Makes sure that cloud version of GitHubEnterprise is used when needed

7c3048a

(#3901, #3922)

Updates (minor) from code review

9b5a815

Stores and uses stored values for configured integration descriptors

672297d

sergeibbb force-pushed the 3901-integrations-support-self-hosted-providers-from-gkdev branch from 15c7e7f to 672297d Compare January 15, 2025 17:47

sergeibbb added 2 commits January 15, 2025 19:06

Rename config integration descriptor

2292551

(#3901, #3922)

Adds a todo for a follow-up ticket

3a04d81

(#3901, #3922)

axosoft-ramint merged commit cb7e263 into main Jan 15, 2025
3 checks passed

sergeibbb added a commit that referenced this pull request Jan 15, 2025

Adds support for GKDev Cloud GitHub Enterprise integration

b8dd1b0

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 15, 2025

Associates a Cloud GitHub Enterprise provider with remote by its domain

a27e8de

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 15, 2025

Adds GitHub Enterprize menu item

714d3ed

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 15, 2025

Filters out GitHub's icon in the bar

b33027c

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 15, 2025

Makes sure that cloud version of GitHubEnterprise is used when needed

97f89b4

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 15, 2025

Rename config integration descriptor

c099605

(#3901, #3922)

sergeibbb added a commit that referenced this pull request Jan 15, 2025

Adds a todo for a follow-up ticket

9c658df

(#3901, #3922)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrations support self hosted providers from gkdev (#3901) #3922

Integrations support self hosted providers from gkdev (#3901) #3922

sergeibbb commented Jan 13, 2025 •

edited

Loading

sergeibbb commented Jan 13, 2025

eamodio left a comment

eamodio Jan 15, 2025

axosoft-ramint Jan 15, 2025

axosoft-ramint Jan 15, 2025

eamodio Jan 15, 2025

axosoft-ramint commented Jan 15, 2025

Integrations support self hosted providers from gkdev (#3901) #3922

Integrations support self hosted providers from gkdev (#3901) #3922

Conversation

sergeibbb commented Jan 13, 2025 • edited Loading

Description

Checklist

sergeibbb commented Jan 13, 2025

eamodio left a comment

Choose a reason for hiding this comment

eamodio Jan 15, 2025

Choose a reason for hiding this comment

axosoft-ramint Jan 15, 2025

Choose a reason for hiding this comment

axosoft-ramint Jan 15, 2025

Choose a reason for hiding this comment

eamodio Jan 15, 2025

Choose a reason for hiding this comment

axosoft-ramint commented Jan 15, 2025

sergeibbb commented Jan 13, 2025 •

edited

Loading