bump golang.org/x/net to v0.33.0 to fix CVE-2024-45338 #1356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps golang.org/x/net to v0.33.0 to fix CVE-2024-45338.
It also bumps mimetype lib to latest v1.4.7.
Notes To Reviewers:
This bump meant to also bump the go version to at least 1.20 because of the usage
subtle.XORBytes
in the crypto lib after the bump.This means we can no longer have the test matrix for go version lower than 1.20 otherwise it will fail with the following error:
See this for more reference, golang/go#68035
More Context:
The CVE is coming from the indirect dependency of golang.org/x/net from https://github.com/gabriel-vasile/mimetype. I think it is worth to update the dependency to fix the CVE and not wait for the release from mimetype!