-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple map renderers #134
base: master
Are you sure you want to change the base?
Conversation
@dwoznicki just a quick follow up on this PR. It's not lost we have just been navigating several other things. We also had to update the package-lock.json file as the CI was timing out. If you're interested in helping with the linter errors you can see what's happening in the Netlify build on this PR: #136 Thanks again for the contribution. |
fixes exceptions that blocked Netlify build
…eturning anything
@ARolek Well, it looks like the build was failing due to a |
@dwoznicki can you rebase against |
…eturning anything
…maplibre-renderer
Related: #133
This PR adds a UI control to change the map render at runtime. Here are some notes/questions for the maintainer(s):
MapMapbox.jsx
to accept multiple renderers instead of creating a new map component because, as far as I can tell, maplibre-gl v2 is completely backwards compatible with mapbox-gl v1. This may not be the case with other renderers, so perhaps there should be a new map component for each renderer (e.g.MapMapbox.jsx
,MapMapLibre.jsx
), even if the Mapbox and MapLibre map components are redundant.npm install
seems to have automatically changed the lock file version to 2, generating a large number of changes topackage-lock.json
. I believe this is because I'm running node v16.15.0 and npm 8.5.5 on my machine. If this is undesirable, let me know what node version I should be working on.