Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose support #1448

Closed
wants to merge 3 commits into from
Closed

Conversation

mgale
Copy link

@mgale mgale commented Dec 28, 2023

Thanks for your pull request, we really appreciate contributions!

Please understand that it may take some time to be reviewed.

Also, make sure to follow the Contribution Guide.

Define the container setup in task yaml file like:

container:
  # Definition needs to be a valid docker-compose definition
  context: default
  definition:
    services:
      container:
        image: ubuntu:latest
        volumes:
          - ./containers/local/config:/local/config:delegated
        environment:
          - FOO:BAR
        command: sleep infinity
        init: true

Either force the task to run in a container by setting the param force_container to true on the task or using the cli arg --force-container

The thought process here is when running locally a container may be optional but might be required when used in a CICD pipeline.

@mgale mgale mentioned this pull request Dec 28, 2023
8 tasks
@andreynering
Copy link
Member

As I also said on #974 (comment), Iḿ closing this on favor of #448.

@mgale
Copy link
Author

mgale commented Apr 9, 2024

@andreynering thanks for taking a look, the concept in #448 looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants