Integration test updates #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add missing export: TEST_DB_HOSTNAME - execute mysqladmin commands inside the running mysql container
asilvas-godaddy
approved these changes
Nov 15, 2024
|
|
||
| const fileDirectory = os.tmpdir() + "/"; | ||
| const fileDirectory = "/tmp/"; |
There was a problem hiding this comment.
This is the working directory for all cross-language tests in the suite. For example, asherah-go encrypts a test payload and writes it to a file in /tmp which is then loaded and decrypted by the asherah-node package (and vice versa).
As it is now, asherah-node's encryption output is not found by the downstream tests in this expected location, resulting in the errors described in #120
See:
asherah-node decrypt:
asherah-go: https://github.com/godaddy/asherah/blob/main/tests/cross-language/go/const.go#L10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
scripts/local-integration-test.sh:TEST_DB_HOSTNAME. This variable is required by the cucumber feature implementation scripts.mysqladmincommands inside the running mysql container, eliminating the client dependency.integration/node/features/support/encrypt.js:decrypt.js(and the integration Asherah integration test suite).integration/node/features/support/decrypt.js:TEST_DB_HOSTNAMEenv variable for consistency (replaced hardcoded "localhost").integration/node(package):asherahas a linked folder.