Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net/ghttp): Server Domain if is empty str, bind handler pattern will add @ which is not expect #4100 #4101

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

elonnzhang
Copy link

if domain != "" {
return pattern + "@" + domain
}
return pattern
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might have something to do with the regular expression at

array, _ := gregex.MatchString(`(.*?)%([A-Z]+):(.+)@(.+)`, k)
The regular expression might better be (.*?)%([A-Z]+):(.+?)@(.+).
You also need commit associated unit testing case for this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants