enforce exact argument count for cmds #302
Open
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
|
@bupd can you please review this PR |
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
|
@bupd can you please see if this is what was required for the issue |
|
@Vad1mo is anything else also required ? |
bupd
requested changes
Jan 9, 2025
| @@ -15,7 +15,7 @@ func CreateLabelCommand() *cobra.Command { | |||
| Short: "create label", | |||
| Long: "create label in harbor", | |||
| Example: "harbor label create", | |||
| Args: cobra.NoArgs, | |||
| @@ -15,6 +15,7 @@ func ListLabelCommand() *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "list", | |||
| Short: "list labels", | |||
| Args: cobra.ExactArgs(0), | |||
There was a problem hiding this comment.
please do cobra.NoArgs
Suggested change
| Args: cobra.ExactArgs(0), | |
| Args: cobra.NoArgs, |
to maintain consistency
Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #293 by giving the below error
This PR reviewed all commands where the No. of arguments were not specified and addresses that and also replaced cobra.NoArgs with cobra.ExactArgs(0) as later gives more defined error.
It also fixes one more issue that was in project create command when no name for project was gien it gave below error
so fixes that to give below error