Add cgolessbuild test job #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
force-pushed
the
dev/dagood/cgolessbuild-ci
branch
from
6993b93 to
835ac83
Compare
dagood
force-pushed
the
dev/dagood/cgolessbuild-ci
branch
from
835ac83 to
990492f
Compare
dagood
requested review from
karianna,
derekparker,
qmuntal,
mertakman and
gdams
karianna
reviewed
Nov 1, 2024
gdams
approved these changes
Nov 1, 2024
karianna
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not totally positive why our fork depends on this. I would have expected that there are no
imports if cgo isn't enabled because we wouldn't try to use the openssl backend. However, I don't think it would be bad to keep this working even if we figure out and remove the dependency.