Windows Support on Build and all of the Tests and Adding Windows to CI #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus unit tests, some documentation.
* Delete client-generation-tests directory * Update openapi_converter.rs * Update openapi_export.rs * Update rib_converter.rs * Update openapi_export.rs * Update openapi_converter.rs * Update swagger_ui.rs * Delete golem-worker-service-base/src/gateway_api_definition/http/tests directory * Update mod.rs * Update mod.rs * Create openapi-integration-tests.yaml * Update openapi-integration-tests.yaml * Update rib_converter.rs
- Added multiple new test files for API integration, OpenAPI conversion, and schema validation. - Introduced new test cases for complex workflows and validation of JSON schemas against OpenAPI specifications. - Updated `Cargo.toml` to include additional dependencies for testing and API functionality. - Removed outdated tests related to Swagger UI and OpenAPI export. - Improved the structure and organization of test cases for better maintainability and clarity.
…n (finally manually tested, 5/7 tests passed, couldnt test it further because of RAM size) - Updated `Cargo.toml` to enable harness for multiple test cases. - Refactored `openapi_converter.rs` to improve path merging logic and component handling. - Enhanced test cases across various modules, including API integration, OpenAPI conversion, and JSON schema validation, to utilize a dynamic test registration framework. - Improved test structure for clarity and maintainability, ensuring comprehensive coverage of complex workflows and validation scenarios. - Removed outdated tests and streamlined existing ones for better performance.
- Updated `Cargo.toml` to enable harness for multiple test cases and adjusted test configurations. - Refactored `rib_converter.rs` to improve schema conversion logic, including the addition of new types and validation mechanisms. - Enhanced test cases across various modules, including API integration, OpenAPI conversion, and JSON schema validation, to utilize a dynamic test registration framework. - Improved the structure and organization of tests for better maintainability and clarity, ensuring comprehensive coverage of complex workflows and validation scenarios. - Removed outdated tests and streamlined existing ones for better performance and reliability.
- Updated `Cargo.toml` to upgrade `rustls` to version 0.23.20, added `rustls-native-certs` and `rustls-pemfile` dependencies. - Introduced a new crate `poule` for managing a pool of reusable values. - Enhanced GitHub Actions CI configuration to support builds on both Ubuntu and Windows, including conditional steps for Redis setup based on the OS. - Improved test execution strategy by implementing a matrix build for various OS environments. - Refactored paths and dependencies in multiple modules to ensure compatibility across platforms.
Fixed CWE-676 in the codebase as well for better memory management and security - Added null check for memory allocation to prevent potential crashes. - Ensured proper string termination when copying from input structure. - Replaced localtime with localtime_r for thread safety in time retrieval. - Freed allocated memory to prevent memory leaks.
…nto Windowsbuilds
|
There was a security and memory leak issue in the original golem repo https://cwe.mitre.org/data/definitions/676.html#Vulnerability_Mapping_Notes_676 Fixed that as well. |
|
@zelosleone There are quite a few serious failures in the CI build. If possible, I would recommend to try to get Github Actions working in your own fork, so you have a fast way to test. I can kick off a CI build from time to time here on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo.tomlto upgraderustlsto version 0.23.20, addedrustls-native-certsandrustls-pemfiledependencies, and updatedwasm-waveto version 0.222.0 (wasm was possible thanks to @vigoo )poulefor managing a pool of reusable values. Refactor memory management and improve platform compatibility for Windows sozu-proxy/poule#4 It passes their tests on local./claim #1210
Deleted codes are mainly from my OpenAPI export module branch. As this is the "windowsbuild" branch, openapi export remains in the main branch of my fork.