-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced seed
with key
#1167
base: main
Are you sure you want to change the base?
replaced seed
with key
#1167
Conversation
@rdyro 3 month later, but I've finished it) |
Also should close issue #1137 after PR got accepted |
@Tomas542 JAX now recommends using |
@carlosgmartin yes, I know, but there are some problems with this in tests where NumPy checks for type compatibility. The new keys are of type P.S. Accidentally, I've made a mistake in |
The changes look great so far! @carlosgmartin is right that we should move to Let me see if we can fix the optax hyperparameter validation before this PR so that we can stick to |
Replaced all seed values with key for uniformity of style with
jax.random