New ion config API. Inputs defined from ion names. #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_714152486
branch
4 times, most recently
from
5561ce4 to
b875a96
Compare
New feature supported for generating IonMixtures based on dict of input ion symbols and fractions in config. Still only supports a single main ion and single impurity species. However, each one of those "species" can be IonMixtures. Overrides are available for ion Z and A. Useful for testing and sensitivity studies, as well as enabling agreement with specific sim test cases. Previous cases with explicit Ai=2 have newly generated sim references since we update the deuterium mass to 2.0141. Those sim test relative differences were on the order of O(1e-4). Next PRs will incorporate the new ion name and mixture features in fusion power and radiation physics models. PiperOrigin-RevId: 716613672
copybara-service
bot
force-pushed
the
test_714152486
branch
from
b875a96 to
2282724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New ion config API. Inputs defined from ion names.
New feature supported for generating IonMixtures based on dict of input ion symbols and fractions in config.
Still only supports a single main ion and single impurity species. However, each one of those "species" can be IonMixtures.
Overrides are available for ion Z and A. Useful for testing and sensitivity studies, as well as enabling agreement with specific sim test cases.
Previous cases with explicit Ai=2 have newly generated sim references since we update the deuterium mass to 2.0141. Those sim test relative differences were on the order of O(1e-4).
Next PRs will incorporate the new ion name and mixture features in fusion power and radiation physics models.