Streaming utf-8 #11
Merged
Streaming utf-8 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5372f24 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hsubox76
reviewed
Dec 15, 2023
| ): ReadableStream<GenerateContentResponse> { | ||
| let currentText = ""; | ||
| const reader = new ReadableStream<Uint8Array>({ |
There was a problem hiding this comment.
Since response.body is a ReadableStream I think we can just pass body to this function and here we can do body.pipeThrough(newTextDecoderStream()).getReader(). But for the tests we'll have to rewrite mockResponse to really make body a ReadableStream instead of an empty object with a getReader() function
alx13
force-pushed
the
issue/utf-parsing
branch
from
b1d3a06 to
cbc7670
Compare
alx13
commented
Dec 15, 2023
hsubox76
reviewed
Dec 15, 2023
| @@ -110,6 +132,37 @@ function readFromReader( | |||
| return stream; | |||
| } | |||
|
|
|||
| function tryParse(currentText: string): { | |||
| leftText: string; | |||
There was a problem hiding this comment.
Can we call this "remainingText"?
hsubox76
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9