Verify RegisterProfilerManager doesn't overwrite an existing registration #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Tested: Add a second registration to test/profiler_manager_test.cc and verify the test crashes as expected.
|
i don't see the test in the PR |
|
Yeah, I wasn't sure how to write a crash test. Is there an existing example? |
|
it would be a standard googletest death test (https://github.com/google/googletest/blob/main/docs/advanced.md#death-tests) .. the test file must end with _gtest.cc so we run it against googletest correctly. but bear in mind we only assert-fatal in debug, not release. |
|
did you manage to figure out the death test? |
…tion Tested: Configure with: cmake -GNinja -DCMAKE_BUILD_TYPE=Debug -DBENCHMARK_DOWNLOAD_DEPENDENCIES=on Then run: ctest -R profiler_manager_gtest Before change test fails (expected), after change test passes (expected)
xdje42
force-pushed
the
i1807-dont-clobber-existing-manager
branch
from
8ded36c to
227bca2
Compare
|
Oops. I was away during August, and this got dropped to the bottom of my queue. |
dmah42
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested:
Configure with:
cmake -GNinja -DCMAKE_BUILD_TYPE=Debug -DBENCHMARK_DOWNLOAD_DEPENDENCIES=on
Then run:
ctest -R profiler_manager_gtest
Before change test fails (expected), after change test passes (expected)