Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Remove selects on CPU #1892

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

keith
Copy link
Contributor

@keith keith commented Dec 20, 2024

In a future version of bazel this produces a warning. In this case using
only the platform being windows is enough. Fixes:

WARNING: /.../benchmark/BUILD.bazel:29:15: in config_setting rule //:windows: select() on cpu is deprecated. Use platform constraints instead: https://bazel.build/docs/configurable-attributes#platforms.

In a future version of bazel this produces a warning. In this case using
only the platform being windows is enough. Fixes:

```
WARNING: /.../benchmark/BUILD.bazel:29:15: in config_setting rule //:windows: select() on cpu is deprecated. Use platform constraints instead: https://bazel.build/docs/configurable-attributes#platforms.
```
@dmah42
Copy link
Member

dmah42 commented Jan 8, 2025

all CI failures are unrelated. forcing merge. thanks :)

@dmah42 dmah42 merged commit 5af40e8 into google:main Jan 8, 2025
75 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants