-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enables strict mode for zoom-to-fit #2034
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
@BeksOmega Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! Thank you for your work on this :D
This is dependent on #2026 so I'm going to hold this for now. You may need to rebase after that gets merged!
Co-authored-by: Beka Westberg <bwestberg@google.com>
Fixes lint indentation errors.
@kapooraryan I think this needs to be rebased and then should be gtg! |
Hey, @BeksOmega I have done the rebase and the PR is ready for review. Reference branch: Branch Link. Edit: Reference I used for the rebase but if anything seems to be wrong, do guide me on how to proceed ahead and thanks. |
@kapooraryan doesn't look like the rebase fixed the merge conflicts. Can you fix the conflicts? Then I can re-review! |
@BeksOmega Done👍. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! Thanks for your work on this :D
The basics
The details
Resolves
Closes #2033
Proposed Changes
Enables strict mode for the zoom-to-fit plugin by configuring "strict": true in tsconfig.json.
Typescript errors that arose as a result:
Solved by making changes to index.ts in the src and test directory:
Reason for Changes
Apart from enabling strict mode, the code now keeps a check for a null object in src/index.ts and a null element in test/index.ts.
Additional Information
Ran npm run lint and resolved any formatting issues as well. Please do let me know if this is okay or any changes need to be made!