Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enables strict mode for zoom-to-fit #2034

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

kapooraryan
Copy link
Contributor

The basics

The details

Resolves

Closes #2033

Proposed Changes

Enables strict mode for the zoom-to-fit plugin by configuring "strict": true in tsconfig.json.

Typescript errors that arose as a result:
Error_TS

Solved by making changes to index.ts in the src and test directory:
Solved_TS

Reason for Changes

Apart from enabling strict mode, the code now keeps a check for a null object in src/index.ts and a null element in test/index.ts.

Additional Information

Ran npm run lint and resolved any formatting issues as well. Please do let me know if this is okay or any changes need to be made!

@kapooraryan kapooraryan requested a review from a team as a code owner October 22, 2023 04:41
@kapooraryan kapooraryan requested review from maribethb and removed request for a team October 22, 2023 04:41
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@kapooraryan
Copy link
Contributor Author

@BeksOmega Ready for review

@BeksOmega BeksOmega assigned BeksOmega and unassigned maribethb Oct 23, 2023
@BeksOmega BeksOmega requested review from BeksOmega and removed request for maribethb October 23, 2023 15:35
Copy link
Contributor

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thank you for your work on this :D

This is dependent on #2026 so I'm going to hold this for now. You may need to rebase after that gets merged!

plugins/zoom-to-fit/src/index.ts Outdated Show resolved Hide resolved
kapooraryan and others added 2 commits October 23, 2023 22:08
Co-authored-by: Beka Westberg <bwestberg@google.com>
Fixes lint indentation errors.
@BeksOmega
Copy link
Contributor

@kapooraryan I think this needs to be rebased and then should be gtg!

@kapooraryan
Copy link
Contributor Author

kapooraryan commented Oct 27, 2023

Hey, @BeksOmega I have done the rebase and the PR is ready for review. Reference branch: Branch Link. Edit: Reference I used for the rebase but if anything seems to be wrong, do guide me on how to proceed ahead and thanks.

@BeksOmega
Copy link
Contributor

@kapooraryan doesn't look like the rebase fixed the merge conflicts. Can you fix the conflicts? Then I can re-review!

@kapooraryan
Copy link
Contributor Author

@kapooraryan doesn't look like the rebase fixed the merge conflicts. Can you fix the conflicts? Then I can re-review!

@BeksOmega Done👍.

Copy link
Contributor

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thanks for your work on this :D

@BeksOmega BeksOmega merged commit dc61d2d into google:master Oct 30, 2023
7 checks passed
@kapooraryan kapooraryan deleted the fixes-issue-2033 branch October 30, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable strict mode for zoom-to-fit
3 participants