Skip to content

Commit

Permalink
Merge pull request #1232 from eustas:fixp1
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 713231604
  • Loading branch information
copybara-github committed Jan 8, 2025
2 parents 57610b7 + 281b0aa commit b01b63a
Show file tree
Hide file tree
Showing 12 changed files with 35 additions and 94 deletions.
31 changes: 16 additions & 15 deletions .github/workflows/build_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,24 +47,25 @@ jobs:
build_system: cmake
c_compiler: clang-15
cxx_compiler: clang++15
os: ubuntu-22.04

- name: cmake:clang15:asan
- name: cmake:clang:asan
build_system: cmake
sanitizer: address
c_compiler: clang-15
cxx_compiler: clang++15
c_compiler: clang
cxx_compiler: clang++

- name: cmake:clang15:tsan
- name: cmake:clang:tsan
build_system: cmake
sanitizer: thread
c_compiler: clang-15
cxx_compiler: clang++15
c_compiler: clang
cxx_compiler: clang++

- name: cmake:clang15:ubsan
- name: cmake:clang:ubsan
build_system: cmake
sanitizer: undefined
c_compiler: clang-15
cxx_compiler: clang++-15
c_compiler: clang
cxx_compiler: clang++
c_flags: -fno-sanitize-recover=undefined,integer

- name: cmake:qemu-arm-neon-gcc
Expand Down Expand Up @@ -98,10 +99,10 @@ jobs:
cmake_config: Debug
os: windows-latest

- name: fuzz:clang15
- name: fuzz:clang
build_system: fuzz
c_compiler: clang-15
cxx_compiler: clang++15
c_compiler: clang
cxx_compiler: clang++

# TODO: consider running this combination in docker
#- name: python2.7:gcc5
Expand Down Expand Up @@ -131,11 +132,11 @@ jobs:
# TODO: consider running this combination in docker
#- name: python3.8:gcc5

- name: python3.10:clang15
- name: python3.10:clang
build_system: python
python_version: "3.10"
c_compiler: clang-15
cxx_compiler: clang++-15
c_compiler: clang
cxx_compiler: clang++

- name: python3.10-win
build_system: python
Expand Down
10 changes: 6 additions & 4 deletions java/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,19 @@ package(

genrule(
name = "copy_link_jni_header",
srcs = ["@openjdk_jni_h//file"],
srcs = ["@bazel_tools//tools/jdk:jni_header"],
outs = ["jni/jni.h"],
cmd = "cp -f $< $@",
)

genrule(
name = "copy_link_jni_md_header",
srcs = select({
"@platforms//os:macos": ["@openjdk_macosx_jni_md_h//file"],
"@platforms//os:windows": ["@openjdk_windows_jni_md_h//file"],
"//conditions:default": ["@openjdk_solaris_jni_md_h//file"],
"@bazel_tools//src/conditions:darwin": ["@bazel_tools//tools/jdk:jni_md_header-darwin"],
"@bazel_tools//src/conditions:freebsd": ["@bazel_tools//tools/jdk:jni_md_header-freebsd"],
"@bazel_tools//src/conditions:openbsd": ["@bazel_tools//tools/jdk:jni_md_header-openbsd"],
"@bazel_tools//src/conditions:windows": ["@bazel_tools//tools/jdk:jni_md_header-windows"],
"//conditions:default": ["@bazel_tools//tools/jdk:jni_md_header-linux"],
}),
outs = ["jni/jni_md.h"],
cmd = "cp -f $< $@",
Expand Down
11 changes: 0 additions & 11 deletions java/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,3 @@ local_path_override(
module_name = "brotli",
path = "..",
)

maven = use_extension("@rules_jvm_external//:extensions.bzl", "maven")
maven.install(
name = "brotli_maven",
artifacts = ["junit:junit:4.13.2"],
repositories = [
"https://maven.google.com",
"https://repo1.maven.org/maven2"
],
)
use_repo(maven, "brotli_maven")
1 change: 0 additions & 1 deletion java/org/brotli/dec/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ licenses(["notice"]) # MIT
TEST_DEPS = [
":dec",
":test_utils",
"@maven//:junit_junit",
]

java_library(
Expand Down
4 changes: 2 additions & 2 deletions java/org/brotli/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.1</version>
<configuration>
<source>1.6</source>
<target>1.6</target>
<source>1.7</source>
<target>1.7</target>
</configuration>
</plugin>
<plugin>
Expand Down
2 changes: 1 addition & 1 deletion java/org/brotli/wrapper/common/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ java_library(
"//org/brotli/dec",
"//org/brotli/integration:brotli_jni_test_base",
"//org/brotli/wrapper/dec",
"@maven//:junit_junit",
"@bazel_tools//tools/jdk:TestRunner",
],
)

Expand Down
2 changes: 1 addition & 1 deletion java/org/brotli/wrapper/dec/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ java_library(
"//org/brotli/integration:brotli_jni_test_base",
"//org/brotli/integration:bundle_helper",
"//org/brotli/wrapper/enc",
"@maven//:junit_junit",
"@bazel_tools//tools/jdk:TestRunner",
],
)

Expand Down
2 changes: 1 addition & 1 deletion java/org/brotli/wrapper/enc/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ java_library(
"//org/brotli/integration:bundle_helper",
"//org/brotli/wrapper/common",
"//org/brotli/wrapper/dec",
"@maven//:junit_junit",
"@bazel_tools//tools/jdk:TestRunner",
],
)

Expand Down
2 changes: 1 addition & 1 deletion research/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ cc_library(
name = "durchschlag",
srcs = ["durchschlag.cc"],
hdrs = ["durchschlag.h"],
deps = ["@divsufsort//:libdivsufsort"],
deps = ["@divsufsort//:divsufsort"],
)

cc_library(
Expand Down
57 changes: 0 additions & 57 deletions research/BUILD.libdivsufsort

This file was deleted.

3 changes: 3 additions & 0 deletions research/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ module(
repo_name = "org_brotli_research",
)

bazel_dep(name = "divsufsort", version = "2.0.1")
bazel_dep(name = "esaxx", version = "20250106.0")

bazel_dep(name = "brotli", version = "1.1.0", repo_name = "org_brotli")
local_path_override(
module_name = "brotli",
Expand Down
4 changes: 4 additions & 0 deletions research/MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b01b63a

Please sign in to comment.